perf: improve skip row group using statistics condition #14056
Merged
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taki-mekhalfa
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
github-actions
bot
added
fix
Old code skipped row groups only if values passed to `is_in` are _ALL_ under min or _ALL_ above max. Improved to skip if _ALL_ values are either under min or above max
taki-mekhalfa
force-pushed
the
fix/is_in_13427
branch
from
8918f07 to
be6a8cc
Compare
taki-mekhalfa
changed the title
|
Small change, great consequences. Thank you very much. :) |
ritchie46
changed the title
|
Thnx @taki-mekhalfa 😄 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 13427
Old code skipped row groups only if values passed to
is_inare ALL under min or ALL above max. Imroved to skip if ALL values are either under min or above max