fix(rust): range/ranges output name should follow lhs rule #13369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reswqa
commented
Jan 2, 2024
| assert result.collect().schema == expected_schema | ||
|
|
||
|
|
||
| def test_time_range_no_alias_schema_9037() -> None: |
There was a problem hiding this comment.
This test is exactly same as test_time_range_schema. So remove it.
reswqa
requested review from
ritchie46,
stinodego,
orlp,
c-peters,
alexander-beedie and
MarcoGorelli
as code owners
|
At least the lhs rule is predictable. Rename your expressions! :) |
ritchie46
approved these changes
Jan 2, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #13314.
Maybe one could argue that It's weird that
pl.int_ranges(5, 0, -1)'s name isliteral. But we prefer to follow the same leftmost rule as the other expressions.