fix(rust,python): fix csv parser error when commented-out rows precede the header row
#13318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
orlp,
c-peters and
MarcoGorelli
as code owners
github-actions
bot
added
fix
ritchie46
reviewed
Dec 30, 2023
| if self.has_header { | ||
| bytes = skip_header(bytes, quote_char, eol_char); | ||
| } | ||
|
|
There was a problem hiding this comment.
Yeap, the argument skip_rows_before_header is pretty clear. ^^
ritchie46
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13022.
The linked issue mentions
raise_if_emptybut that's a red herring; the real issue is that we were trying to skip the header row before we had skipped the pre-header rows (including comments), instead of after. Reordering those two operations so that the correct lines are skipped solves the error.Added some additional comment/skip permutations to the existing test coverage.
Also: the slightly misleadingly-named
skip_headerfunction didn't actually have any header-specific logic; was just a simple redirect toskip_this_line, so we may as well just call that directly.