Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust,python,cli): support common variant spelling STDEV in the SQL engine (in addition to STDDEV) #13303

Merged
merged 1 commit into from Dec 28, 2023

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Dec 28, 2023

Closes #13302.

It's a coin-flip as to which spelling ("stdev" or "stddev") is used in different database dialects, and there's no harm in supporting both; will make it a little more accessible if you're not a longtime PostgreSQL user (also added support for "var" as an alias for "variance" for much the same reason - didn't add "std" for "stddev" as it is potentially a little more ambiguous and less widely used).

Added new test coverage for both "stddev" and "variance".

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Dec 28, 2023
@alexander-beedie alexander-beedie added the A-sql Area: Polars SQL functionality label Dec 28, 2023
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@alexander-beedie alexander-beedie merged commit 595bfe4 into pola-rs:main Dec 28, 2023
29 checks passed
@alexander-beedie alexander-beedie deleted the sql-stdev branch December 28, 2023 22:14
@alexander-beedie alexander-beedie changed the title feat(rust,python,cli): support common variant spelling STDEV in the SQL engine feat(rust,python,cli): support common variant spelling STDEV in the SQL engine (in addition to STDDEV) Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql Area: Polars SQL functionality enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for STDEV in SQL
3 participants