feat: Allow step parameter in int_ranges to take an expression
#13148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reswqa
changed the title
step parameter in int_ranges to take an expression
github-actions
bot
added
enhancement
|
It seems that For further investigation: |
reswqa
requested review from
ritchie46,
stinodego,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
stinodego
changed the title
step parameter in int_ranges to take an expressionstep parameter in int_ranges to take an expression
ritchie46
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretically we can expressify
step/intervalfor both numeric and temporal ranges, but only the former is supported here. Things are more complicated for temporal ranges:intervalparameter, we do not want it to participate in the casting of common super type withstart & end. We could add new special branch to the type conversion rule, but I'd like to see a more general solution, especially as we increasingly turn arguments into expressions.datetime_ranges, the type conversion ofstart/enddepends in part on the value ofinterval.So I think of it as follow-up PR(At that time, maybe we can unify
temporal_ranges_impl_broadcastandnumeric_ranges_impl_broadcast, or maybe we can't. Sometimes it's hard to unify the handling of numeric and utf8 types without using macros, but I don't like it).