feat: Support Array dtype AnyValue Series construction
#12817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
MarcoGorelli and
orlp
as code owners
github-actions
bot
added
enhancement
alexander-beedie
force-pushed
the
feat-anyvalue-array
branch
from
4f33961
to
4ee2a8e
Compare
ritchie46
requested changes
Dec 2, 2023
| @@ -235,6 +235,10 @@ impl Series { | |||
| any_values_to_decimal(av, *precision, *scale)?.into_series() | |||
| }, | |||
| DataType::List(inner) => any_values_to_list(av, inner, strict)?.into_series(), | |||
| #[cfg(feature = "dtype-array")] | |||
| DataType::Array(inner, size) => any_values_to_list(av, inner, strict)? | |||
There was a problem hiding this comment.
This will allocate list offsets where we don't have to.
We should add a any_values_to_array. This one can piggy back on any_values to series creation and then store the array in the an arrow fixedsize list.
There was a problem hiding this comment.
Will come back to this; parking in draft for a bit馃憣
alexander-beedie
force-pushed
the
feat-anyvalue-array
branch
from
4ee2a8e
to
885e1ff
Compare
stinodego
changed the title
Array dtype AnyValue Series constructionArray dtype AnyValue Series construction
ritchie46
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12719.
Observationally the cast from
ListtoArrayis (as expected) extremely cheap (eg: a "with_columns" cast of a 25_000_000 x 4Listcol toArrayonly takes 0.0096 secs), so this PR seems to be a simple/minimal way to supportArrayAnyValues (absent a dedicated micro-optimised path 馃)This opens up
Arrayusage to additional constructors, such aspl.from_dictsin the linked issue, which otherwise fail.