New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): enhance expression-level filter
syntax with support for multiple predicates and kwargs
#12689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego and
MarcoGorelli
as code owners
November 26, 2023 07:50
github-actions
bot
added
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
labels
Nov 26, 2023
rancomp
reviewed
Nov 26, 2023
ritchie46
changed the title
feat(python): enhance expression-level
feat(python!): enhance expression-level Nov 27, 2023
filter
syntax with support for multiple predicates and kwargsfilter
syntax with support for multiple predicates and kwargs
github-actions
bot
added
the
breaking python
Change that breaks backwards compatibility for the Python package
label
Nov 27, 2023
Nice! I wait merging this when we merge the breaking changes ( soon ). |
No problem to wait, but this change isn't actually breaking ;) |
This new style is very convinient but does it translate to the same filter? See #12932 |
alexander-beedie
removed
the
breaking python
Change that breaks backwards compatibility for the Python package
label
Dec 18, 2023
alexander-beedie
changed the title
feat(python!): enhance expression-level
feat(python): enhance expression-level Dec 18, 2023
filter
syntax with support for multiple predicates and kwargsfilter
syntax with support for multiple predicates and kwargs
alexander-beedie
force-pushed
the
expr-filter-kwargs
branch
from
December 18, 2023 15:20
b46a78f
to
bef3d85
Compare
…or multiple predicates and kwargs
alexander-beedie
force-pushed
the
expr-filter-kwargs
branch
from
December 28, 2023 18:31
bef3d85
to
71c6e67
Compare
@ritchie46: rebased and added an "explain" check to confirm that we reduce |
Great! |
ritchie46
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12577 (following up #12603).
Adds the same support for multiple predicates and kwargs as recently added to frame-level
filter
andwhen/then
.Example