Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: don't add random IDs to temp file names #6817

Merged
merged 2 commits into from
Jul 17, 2023
Merged

perf: don't add random IDs to temp file names #6817

merged 2 commits into from
Jul 17, 2023

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Jul 16, 2023

Related changes: zkochan/packages@f730084

This is one of the improvements suggested by @dmichon-msft in this comment

Copy link
Contributor

@dmichon-msft dmichon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to go look into the other package to understand the actual change. Might be useful to include in the PR description or changelog that it now uses the PID as the unique suffix for temp files.

What setup do you usually use for perf testing changes?

@zkochan
Copy link
Member Author

zkochan commented Jul 17, 2023

I use this package for performance testing: https://github.com/pnpm/pnpm.io/blob/main/benchmarks/fixtures/alotta-files/package.json

@zkochan zkochan merged commit e958707 into main Jul 17, 2023
13 of 14 checks passed
@zkochan zkochan deleted the path-temp branch July 17, 2023 08:35
@zkochan zkochan changed the title perf: don't random ID to temp file names perf: don't add random IDs to temp file names Jul 17, 2023
@zkochan
Copy link
Member Author

zkochan commented Jul 18, 2023

While updating pnpm in bit, a test failed:

     Error: Command failed: bit link  --rewire
** unhandled rejection found, please make sure the promise is resolved/rejected correctly! **
ENOENT: no such file or directory, stat '/home/circleci/.local/share/pnpm/store/v3/files/0e/881c510be971ed3ac667f69eb22ccf57c377f2e6c4ffeae310e7332ba0609bf716e5f33bc3e05f7d8e0d0572ffbd9f9d12815865eb3c6f077b789701be5a71-exec_tmp_1869'

I am not currently sure how these changes could cause the issue. Might be unrelated but I don't remember seeing such error in the past.

@zkochan
Copy link
Member Author

zkochan commented Jul 18, 2023

Looks like it is happening because the locker is created multiple times. I don't think it affects pnpm CLI, just bit CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants