-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: don't add random IDs to temp file names #6817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to go look into the other package to understand the actual change. Might be useful to include in the PR description or changelog that it now uses the PID as the unique suffix for temp files.
What setup do you usually use for perf testing changes?
I use this package for performance testing: https://github.com/pnpm/pnpm.io/blob/main/benchmarks/fixtures/alotta-files/package.json |
While updating pnpm in bit, a test failed:
I am not currently sure how these changes could cause the issue. Might be unrelated but I don't remember seeing such error in the past. |
Looks like it is happening because the locker is created multiple times. I don't think it affects pnpm CLI, just bit CLI. |
Related changes: zkochan/packages@f730084
This is one of the improvements suggested by @dmichon-msft in this comment