Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: spo page section add extend *zoneEmphasis* option to handle images #6037

Open
mkm17 opened this issue May 8, 2024 · 3 comments

Comments

@mkm17
Copy link
Contributor

mkm17 commented May 8, 2024

Hi, in the latest updates of SharePoint Online, there's a new feature allowing you to set different types of section backgrounds.

Here are the options that I can see in the page source when the background image option is used.

Option Values
--zoneEmphasis [zoneEmphasis] None, Neutral, Soft, Strong, Image (the new one)
--imageUrl [imageUrl ] background Image URL (if skipped the default one would be set)
--imageHeight [imageHeight] background image height
--imageWidth [imageWidth] background image width
--useLightText useLightText parameter for background
--overlayColor [overlayColor ] overlay color for background
--overlayOpacity [overlayOpacity ] overlay opacity for background

Is it worth adding so many new parameters for this single option? Perhaps you have any recommendations regarding this matter.
I will also explore the gradient option; maybe some parameters could be shared (like overlay ones).

And if you don't mind, I can take on this task, as I have already conducted some research."

@Jwaegebaert Jwaegebaert added enhancement needs peer review Needs second pair of eyes to review the spec or PR needs research and removed needs peer review Needs second pair of eyes to review the spec or PR labels May 14, 2024
@Jwaegebaert
Copy link
Contributor

That would be a great enhancement. We definitely need to validate gradients too. If we're adding background images, we should consider gradients as well. Adding all these options to spo page section add seems like the best approach. We could also use spo page section background set, but that feels a bit overkill. One more feature I'd like is setting a focus point for the image. It's not the easiest to define, but it's quite interesting.

@Adam-it
Copy link
Contributor

Adam-it commented May 14, 2024

@mkm17 awesome suggestion:

  • I am also fine in adding those as additional/new options. We already have commands with a looot of options like spo site set
  • what should be the possible options for overlayColor? white/dark?
  • BTW I think we also don't have options to define it as collapsible and the following 😉. Why don't we try to tackle those as well? Also since those are not 'that new' 🙂
    image

@mkm17
Copy link
Contributor Author

mkm17 commented May 15, 2024

@Jwaegebaert, thank you for the comment. I will then check the gradient option and extend the specification of the command. Regarding the focus, I believe it may need to be handled by the height and width parameters, but I am not sure how to handle it.

@Adam-it, ok, I will check how it is set and add it to the specification 😄 The overlayColor can be provided in #rrggbb format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants