Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the m365 spe containertype add with more options to specify application #5990

Open
Tracked by #5731
Adam-it opened this issue Apr 23, 2024 · 3 comments
Open
Tracked by #5731

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Apr 23, 2024

in issue #5767
We added a new command m365 spe containertype add that allows only to specify the parent application by applicationId.
What we could do is extend this command with new options: applicationName and applicationObjectId.
This will allow a more user friendly approach to define new Container Type using names rather than guids.

Internally what we could do is try to resolve the app by name. If more than one will be found CLI should show a prompt (when interactive mode) to pick the correct app by id. After CLI will get the app by name or object id we should use the app id (client id) to create a new Container Type

@Adam-it Adam-it added enhancement needs peer review Needs second pair of eyes to review the spec or PR labels Apr 23, 2024
@milanholemans milanholemans added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Apr 25, 2024
@arenk
Copy link

arenk commented May 9, 2024

I'll leave this comment here since there was a discussion on the region parameter in #5767 (already closed).

To my knowledge, the region must support Microsoft.Syntex - far less options than what is offered when you create a new resource group.

-> it might make sense to update the docs when working on this functionality again.

This is the error message I got when I tried to use germanywestcentral as region parameter:

The provided location 'germanywestcentral' is not available for resource type 'Microsoft.Syntex/accounts'. List of available regions for the resource type is 'eastus,centralus,westcentralus,westus,southcentralus, northcentralus,eastus2,canadacentral,canadaeast,brazilsouth,northeurope,norwayeast,norwaywest,francecentral,francesouth,switzerlandnorth,switzerlandwest,uksouth,ukwest,germanynorth,westeurope,australiaeast,australiasoutheast,centralindia,southindia,westindia,eastasia,southeastasia,japaneast,koreacentral,uaenorth,southafricanorth,southafricawest'."}}.

@Adam-it
Copy link
Contributor Author

Adam-it commented May 9, 2024

@arenk good tip. I was not aware of that either 👍. I will research this a bit and lets include it in the docs so it will be clear for others in future

@arenk
Copy link

arenk commented May 10, 2024

Maybe a few more details: For each container type, a Microsoft Syntex account will be created within the resource group specified in the resource group parameter. One can see the Syntex account in the resource group overview in the Azure portal if "Show hidden types" is enabled. I assume this account is then used for billing purposes.

I've been successful in creating a container type where the location of the resource group does not match the region of the Syntex account (for example, that is currently required in Germany, since I can create resource groups for germanywestcentral only, but Syntex is only available in germanynorth).

This is all just based on my observations, not on official docs 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants