-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zdog support seems to be broken since v9 #1665
Comments
I've never really use Zdog, I imagine the target came in as a contribution so equally we would need someone else who knows zDog to resolve this issue. If you're interested in looking at it, then i'm happy to support you where ever I can! 👍🏼 |
Ok, I'll take a look for myself and try to contact the Zdog team as well. |
If you need anything @AurelienDud, just ask! 😄 |
@joshuaellis I just saw in the code that you are the official maintainer 😄 |
@joshuaellis i got the problem! In @react-spring/zdog a list of Zdog primitives is defined as an array of strings according Zdog component names..
But a string is not suitable to let @react-spring/animated create a custom React element.
I attach a quick patch to this message: |
i've released a beta |
🐛 Bug Report
I'm trying to use React-Spring with Zdog.
But the syntax <a.Shape /> (or any other Zdog component) throw these errors:
<Shape /> is using incorrect casing. Use PascalCase for React components, or lowercase for HTML elements.
The tag <Shape> is unrecognized in this browser. If you meant to render a React component, start its name with an uppercase letter.
To Reproduce
The Zdog's official example use React-Spring 8.0.21.
Increase the React-Spring version beyond v9 will reproduce the issue.
Add the package @react-spring/zdog doesn't solve the problem.
Expected behavior
No syntaxe error
Link to repro (highly encouraged)
A simple reproduction example:
https://codesandbox.io/s/react-spring-zdog-issue-9g0e2
The official Zdog's codesandbox example:
https://codesandbox.io/s/nervous-feather-vk9uh
Environment
I tried various combinations of packages versions but that always fail from React-Spring v9.
The problem seems not to be related to the Zdog or React-Zdog version in use.
The text was updated successfully, but these errors were encountered: