Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1582 #1585

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Fix issue 1582 #1585

merged 1 commit into from
Jun 28, 2021

Conversation

Vazgen7788
Copy link
Contributor

@Vazgen7788 Vazgen7788 commented Jun 24, 2021

What

Fix issue 1582

Why

eachProp function accepts argument primitives which type is Array.
Iteration works over Array.prototype and in case there is a boolean it throws an error. It should use only values from primitives and should not iterate over Array.prototype.

Screen Shot 2021-06-24 at 15 17 23

Checklist

  • Documentation updated
  • Demo added
  • Ready to be merged

Sorry, something went wrong.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 58dcf36:

Sandbox Source
spring-card Configuration
spring-goo-blobs Configuration
spring-flip-card Configuration
spring-slide Configuration
spring-draggable-list Configuration
spring-cards-stack Configuration
spring-viewpager Configuration
spring-simple-transition Configuration
spring-image-fade Configuration
spring-list-reordering Configuration

@joshuaellis joshuaellis linked an issue Jun 28, 2021 that may be closed by this pull request
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution! ⭐

@joshuaellis joshuaellis merged commit f1cb4b7 into pmndrs:master Jun 28, 2021
cameron-martin pushed a commit to cameron-martin/react-spring that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot create property 'Symbol(AnimatedComponent)
2 participants