fix(parallax): scrollTo gets correct scroll value #1455
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would me looking at one of the demos be a good way of testing this change? If so which one? |
|
Yes, parallax-vert. The horizontal one still looks weird (PR for that is next). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolves #1454. Parallax will now animate
scrollTocorrectly.What
Changed the destructuring of the
valueofcontrollerinonChange.I also added a line at 212 to set the
controller's value tostate.currentbefore animating because otherwise it started with stale state (In the current versionstate.currentwill cause thecontrollerto always start at the number from the previous call toscrollTo).Checklist