charts/deployment-operator/Chart.yaml

@@ -1,8 +1,8 @@
 apiVersion: v2
 name: deployment-operator
 description: creates a new instance of the plural deployment operator
-appVersion: 0.5.10
-version: 0.5.10
+appVersion: 0.5.11
+version: 0.5.11
 maintainers:
   - name: Plural
     url: https://www.plural.sh

pkg/common/common.go

@@ -22,7 +22,8 @@ func ToUnstructured(obj runtime.Object) (*unstructured.Unstructured, error) {
 		return nil, err
 	}
 
-	return &unstructured.Unstructured{Object: objMap}, nil
+	unstructured := &unstructured.Unstructured{Object: objMap}
+	return unstructured, nil
 }
 
 func Unmarshal(s string) (map[string]interface{}, error) {

pkg/common/health.go

@@ -76,6 +76,13 @@ var (
 		Status:  HealthStatusProgressing,
 		Message: "Waiting to Autoscale",
 	}
+
+	nonstaleGvks = []schema.GroupVersionKind{
+		{Group: "cert-manager.io", Kind: "Certificate"},
+		{Group: "deployments.plural.sh", Kind: "MetricsAggregate"},
+		{Group: "deployments.plural.sh", Kind: "KubecostExtractor"},
+		{Group: "deployments.plural.sh", Kind: "UpgradeInsights"},
+	}
 )
 
 type hpaCondition struct {
@@ -902,7 +909,7 @@ func GetOtherHealthStatus(obj *unstructured.Unstructured) (*HealthStatus, error)
 
 				// status older than 5min
 				cutoffTime := metav1.NewTime(time.Now().Add(-5 * time.Minute))
-				if cond.LastTransitionTime.Before(&cutoffTime) {
+				if cond.LastTransitionTime.Before(&cutoffTime) && staleIsFailing(obj) {
 					status = HealthStatusDegraded
 				}
 
@@ -918,3 +925,15 @@ func GetOtherHealthStatus(obj *unstructured.Unstructured) (*HealthStatus, error)
 
 	return defaultReadyStatus, nil
 }
+
+func staleIsFailing(obj *unstructured.Unstructured) bool {
+	gvk := obj.GetObjectKind().GroupVersionKind()
+
+	for _, val := range nonstaleGvks {
+		if val.Group == gvk.Group && val.Kind == gvk.Kind {
+			return true
+		}
+	}
+
+	return false
+}

pkg/common/health_test.go

@@ -81,6 +81,8 @@ var _ = Describe("Health Test", Ordered, func() {
 				},
 			}
 			obj, err := common.ToUnstructured(customResource)
+			obj.SetAPIVersion("deployments.plural.sh/v1alpha1")
+			obj.SetKind("MetricsAggregate")
 			Expect(err).NotTo(HaveOccurred())
 			status, err := common.GetResourceHealth(obj)
 			Expect(err).NotTo(HaveOccurred())