Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Deserialize on NamedColor #264

Closed
LafeWessel opened this issue Dec 19, 2024 · 1 comment
Closed

Derive Deserialize on NamedColor #264

LafeWessel opened this issue Dec 19, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@LafeWessel
Copy link

It would be nice to have Deserialize derived on the NamedColor enum. It appears that Serialize is already derived for it. It would also probably be nice to have Deserialize for the other color structs, namely Rgb and Rgba.
@andrei-ng andrei-ng added the good first issue Good for newcomers label Dec 20, 2024
@andrei-ng
Copy link
Collaborator

Should be straightforward. Will try to add it.

andrei-ng added a commit that referenced this issue Dec 31, 2024
@andrei-ng
add deserialize to NamedColor, Rgb, Rgba

Verified

This commit was signed with the committer’s verified signature.
andrei-ng Andrei NG
SSH Key Fingerprint: lRtxQq++oh8xj169okBPGQQ4S/xlxdo2pQHUqJrNRm8
Verified
Learn about vigilant mode
Loading
Loading status checks…
e380138 
Fixes #264

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
andrei-ng added a commit that referenced this issue Jan 2, 2025
@andrei-ng
implement deserialize to NamedColor, Rgb, Rgba

Verified

This commit was signed with the committer’s verified signature.
andrei-ng Andrei NG
SSH Key Fingerprint: lRtxQq++oh8xj169okBPGQQ4S/xlxdo2pQHUqJrNRm8
Verified
Learn about vigilant mode
Loading
Loading status checks…
cf41a5b 
 - remove prefix test_ from all unittest function names

Fixes #264

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
andrei-ng added a commit that referenced this issue Jan 2, 2025
@andrei-ng
implement deserialize to NamedColor, Rgb, Rgba

Verified

This commit was signed with the committer’s verified signature.
andrei-ng Andrei NG
SSH Key Fingerprint: lRtxQq++oh8xj169okBPGQQ4S/xlxdo2pQHUqJrNRm8
Verified
Learn about vigilant mode
Loading
Loading status checks…
6b936ac 
 - remove prefix test_ from all unittest function names

Fixes #264

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
andrei-ng added a commit that referenced this issue Jan 2, 2025
@andrei-ng
implement deserialize to NamedColor, Rgb, Rgba

Verified

This commit was signed with the committer’s verified signature.
andrei-ng Andrei NG
SSH Key Fingerprint: lRtxQq++oh8xj169okBPGQQ4S/xlxdo2pQHUqJrNRm8
Verified
Learn about vigilant mode
Loading
Loading status checks…
4481d95 
 - remove prefix test_ from all unittest function names

Fixes #264

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrei-ng @LafeWessel