-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide minimal padding for inside tick labels case of bar, heatmap, line plots #5325
Conversation
@archmoj this looks great for including padding in the cases it was previously ignored. Do you want to sort out why the line case is getting such huge padding in the y direction in this PR, or do that in a separate PR? |
I'll try to address it in this PR. |
the heatmap case is a bit of an edge-case but this seems correct to me. I'm not sure what the point would be of putting the labels on the inside for a heatmap but if that's what they're asking for that's what they should get, I think. An eventual |
0581849
to
cf68ae7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💃
Fixes #5322 and fixes #5321 (padding for line plots & unnecessary padding).
Demo1:
bar
Before vs After
Demo2:
line plot
Before vs After
Demo3:
heatmap
Before vs After
TODO:
@plotly/plotly_js