Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dm_conversation_id to TDMEventV2Field #547

Merged
merged 7 commits into from
Nov 10, 2024
Merged

Conversation

RenKoya1
Copy link
Contributor

@PLhery
Copy link
Owner

PLhery commented Oct 21, 2024

Thank you! Actually the rest of the fields seem wrong, maybe you could try to fix that too?

@RenKoya1
Copy link
Contributor Author

Okay!

@PLhery
Copy link
Owner

PLhery commented Oct 31, 2024

Hello,

I believed you added "texts" to BaseDMEventV2, but I don't think "ParticipantsJoin" events have text

What I meant is that the other TDMEventV2Field accepted strings seemed wrong to me, maybe I'm wrong

@RenKoya1
Copy link
Contributor Author

RenKoya1 commented Nov 7, 2024

Hello,

I believed you added "texts" to BaseDMEventV2, but I don't think "ParticipantsJoin" events have text

What I meant is that the other TDMEventV2Field accepted strings seemed wrong to me, maybe I'm wrong

My bad. I fixed it

@PLhery
Copy link
Owner

PLhery commented Nov 10, 2024

thank you! (id, name, event type are missing too, I'll add them myself)

@PLhery PLhery merged commit 7acc1d1 into PLhery:master Nov 10, 2024
@PLhery
Copy link
Owner

PLhery commented Nov 10, 2024

Published in 1.18.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants