qunit/resolve-async doesn't recognise .call/.apply

[edg2s]

The following example fails linting, despite done being called in three different ways

beforeEach: function ( assert ) {
	var done = assert.async();
	done.call( this );
	done.apply( this );
	$.Deferred().promise().resolve().then( done );
}

the third case being what we use here: https://github.com/wikimedia/VisualEditor/blob/master/tests/ce/ve.ce.Surface.test.js#L10

[platinumazure]

Hi @edg2s, thanks for the issue.

I would regard the first two (.call, .apply) as bugs, since the intention was to catch direct calls and those are equivalent to the simple function call.

The last, I would say is a rule enhancement. I'm not sure whether I want to allow all function calls with the callback being passed (either by option or by default), or if instead we could use AST selectors to ensure that only certain function calls with the callback would "count" (e.g., must be a call to .then()). What are your thoughts?

[edg2s]

I think whitelisting the caller to then would be acceptable. That would match ES6 & jQuery promises.

[platinumazure]

The .call/.apply issue will be resolved with the upcoming 5.0.0 release.

I'll create a separate issue for the enhancement request of tracking if the callback is passed to specific methods such as .then.