Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"no-identical-title" rule #56

Closed
Turbo87 opened this issue Feb 28, 2017 · 6 comments
Closed

"no-identical-title" rule #56

Turbo87 opened this issue Feb 28, 2017 · 6 comments

Comments

@Turbo87
Copy link
Member

Turbo87 commented Feb 28, 2017

It would be great to have something like https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/docs/rules/no-identical-title.md but for QUnit instead.

@platinumazure
Copy link
Collaborator

Agreed, I'd been pondering writing a rule for this myself.

Not sure if it should be applied differently at test vs module level, though, any thoughts on that? (e.g., if a test has the same name as module, should we even bother searching for that?)

@Turbo87
Copy link
Member Author

Turbo87 commented Feb 28, 2017

@platinumazure I guess we should apply the same logic as in the mocha implementation and treat tests as nested within modules. That means tests can have the same name as their parent modules.

@platinumazure
Copy link
Collaborator

Sounds good to me. Are you interested in writing a pull request?

@Turbo87
Copy link
Member Author

Turbo87 commented Feb 28, 2017

Interested yes, not sure if I'll find time to do it though... 😞

@platinumazure
Copy link
Collaborator

@Turbo87 No problem, just post again here if you think you'll find time to do it soon (e.g., if you think you have a good weekend coming up, you can just say "I'm hoping to take a crack at it this weekend" or similar). I'll do the same if I find time. Thanks!

@Turbo87
Copy link
Member Author

Turbo87 commented Feb 28, 2017

looks like I was annoyed enough by our test suite to just implement it directly... 😄

see #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants