Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule: Forbid (binary) logical operators in assertion arguments #50

Closed
platinumazure opened this issue Aug 16, 2016 · 0 comments
Closed

New rule: Forbid (binary) logical operators in assertion arguments #50

platinumazure opened this issue Aug 16, 2016 · 0 comments
Labels
accepted new rule
Milestone
2.2.0

Comments

@platinumazure
Copy link
Collaborator

platinumazure commented Aug 16, 2016 •
edited
Loading

Binary logical operators should never be needed in assertion arguments. Usually it should be possible to decompose the assertion into multiple assertions if needed.

Additionally, using logical-or in an assertion may be a sign that a test is non-deterministic.
@platinumazure platinumazure mentioned this issue Aug 16, 2016
Closed
@platinumazure platinumazure changed the title New rule: Forbid logical operators in assertion arguments New rule: Forbid (binary) logical operators in assertion arguments Aug 22, 2016
@platinumazure platinumazure added this to the 2.2.0 milestone Aug 26, 2016
platinumazure added a commit that referenced this issue Aug 27, 2016
@platinumazure
New: no-assert-logical-expression rule (fixes #50)

Verified

This commit was signed with the committer’s verified signature. The key has expired.
platinumazure Kevin Partington
GPG key ID: 4FA93B7C68F0C5B5
Expired
Verified
Learn about vigilant mode
f894764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted new rule
Milestone
2.2.0
Development

No branches or pull requests
1 participant
@platinumazure