Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-negated-ok should not warn on global ok #30

Closed
platinumazure opened this issue Apr 26, 2016 · 0 comments
Closed

no-negated-ok should not warn on global ok #30

platinumazure opened this issue Apr 26, 2016 · 0 comments
Labels
accepted bug
Milestone
0.9.0

Comments

@platinumazure
Copy link
Collaborator

The no-negated-ok rule should not warn on ok(!something). This is because there is no global notOk assertion.

There is also no point in warning for global notOk either, since that isn't a real assertion.

In summary, this rule should only really be enforced for MemberExpression assert.ok and assert.notOk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted bug
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@platinumazure