Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo of deepEqual assert name in require-object-in-propequal rule doc #166

Merged
merged 1 commit into from
Apr 4, 2021
Merged

Fix typo of deepEqual assert name in require-object-in-propequal rule doc #166

merged 1 commit into from
Apr 4, 2021
+1 −1

Conversation

bmish
Copy link
Member

@bmish bmish commented Apr 1, 2021

deepStrictEqual does not exist in qunit (it only exists in Node). deepEqual is strict in qunit.

https://api.qunitjs.com/assert/deepEqual/

@coveralls
Copy link

coveralls commented Apr 1, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling fd95c44 on bmish:docs-typo-require-object-in-propequal-deep-equal into 05233bc on platinumazure:master.

platinumazure
platinumazure approved these changes Apr 2, 2021
View reviewed changes
Copy link
Collaborator

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing!

@platinumazure platinumazure merged commit 91f8240 into qunitjs:master Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platinumazure platinumazure

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bmish @coveralls @platinumazure