Allow tests with identical names in different modules in no-identical-names rule

[bmish]

Significantly refactors/simplifies logic.

Fixes #130.

[coveralls]

Coverage remained the same at 100.0% when pulling 6f389f9 on bmish:no-invalid-names-fix-test-check into 479ab16 on platinumazure:master.

[platinumazure]

Thanks for putting this together! Left one question, let me know what you think.

[platinumazure]

Should this second test, outside all modules, be flagged? I feel like it should.

[bmish]

Yes, it should be flagged, so I marked this PR as a draft since I am going to need to do some refactoring / add a stack to handle this case.

test("it1", function() {});
module("module1", function() {});
test("it1", function() {}); // This should be a violation.

[platinumazure]

Thanks! Let me know when it's ready for review again or if you need any help.

[bmish]

@platinumazure I'm having some second thoughts about this. Technically, the second test is part of a separate module, so we should allow it. If we want to disallow top-level tests from having the same title even if they're in different modules, that would require a special case, and I'll likely want to handle that in a separate PR.

[platinumazure]

Technically, the second test is part of a separate module, so we should allow it. If we want to disallow top-level tests from having the same title even if they're in different modules, that would require a special case, and I'll likely want to handle that in a separate PR.

Would you mind elaborating on this? What do you mean the tests are in separate modules?

[bmish]

My bad, I was wrong about that, the tests from my last example are in the same module, thus being considered a violation. To clarify, here are two test cases:

Invalid:

test("it1", function() {});
module("module1", function() {});
test("it1", function() {}); // Violation

Valid:

test("it1", function() {});
module("module1");
test("it1", function() {}); // This is in module1, so not a violation

I have updated the implementation to reflect this.

[platinumazure]

Thanks @bmish for clarifying. I'll give this another review this weekend.

[bmish]

@platinumazure ready for review, fixes the ticket linked, and significantly cleans up / simplifies the rule logic which had become messy over time.

[platinumazure]

Looks good to me, thanks for contributing!

[bmish]

@platinumazure can you publish a patch release with this?

[platinumazure]

@bmish I published a minor release just now!