Fix false positives with nested modules in no-identical-names rule
#123
Conversation
| `, | ||
| outdent` | ||
| module("name1", function() { | ||
| module("name1", function() {}); |
There was a problem hiding this comment.
I'm not sure this should be a valid case. We definitely want to support submodules with the same name under nested modules because there's no chance for ambiguity when you look at the nested module stacks. But I'm not sure that is the case for a nested submodule with the same name as an ancestor module.
What do you think?
There was a problem hiding this comment.
Yeah I'd be open to flagging this case as a violation. But we should do that in a separate PR. My current PR is about fixing false positives whereas this change would be fixing a false negative.
There was a problem hiding this comment.
Sounds good, but would you mind removing this new "valid" test case from this PR in that case? That's just in case I lose track of things and cut a release after merging this PR but before we fix the issue I've raised.
There was a problem hiding this comment.
Sure! I removed this test case to avoid confusion.
bmish
force-pushed
the
no-identical-names-nested-modules-fix
branch
from
5c73825 to
43eba2a
Compare
bmish
force-pushed
the
no-identical-names-nested-modules-fix
branch
from
43eba2a to
b8b759d
Compare
Fixes #120.
CC: @mongoose700