Add new rule no-assert-equal-boolean
#121
Merged
+293
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
no-assert-equal-boolean
branch
3 times, most recently
from
f729996 to
4e5123e
Compare
mongoose700
reviewed
Nov 9, 2020
lib/rules/no-assert-equal-boolean.js
Outdated
| if (!booleanArgument.value) { | ||
| countNegations++; | ||
| } | ||
| const newAssertionFunctionName = countNegations % 2 === 0 ? "true" : "false"; |
There was a problem hiding this comment.
This could be simplified to booleanArgument.value ? "true" : "false".
bmish
force-pushed
the
no-assert-equal-boolean
branch
from
4e5123e to
efad896
Compare
mongoose700
approved these changes
Nov 9, 2020
bmish
force-pushed
the
no-assert-equal-boolean
branch
from
efad896 to
2fd5632
Compare
bmish
force-pushed
the
no-assert-equal-boolean
branch
from
2fd5632 to
27391ed
Compare
|
@platinumazure ready for review. |
platinumazure
requested changes
Nov 24, 2020
lib/rules/no-assert-equal-boolean.js
Outdated
| }, | ||
| fixable: "code", | ||
| messages: { | ||
| general: "Use assert.true(...) or assert.false(...) for boolean assertions." |
There was a problem hiding this comment.
Some thoughts on the message:
- "general" is a very general messageId, let's use something more specific (not attached to anything in particular)
- I like using backticks for code references
- I don't think "(...)" adds much useful info. I would be okay with no parentheses or just "()".
I've provided a suggestion to remove the parentheses altogether and use a different messageId, but I'm not strongly attached to those particular changes.
Suggested change
| general: "Use assert.true(...) or assert.false(...) for boolean assertions." | |
| useAssertTrueOrFalse: "Use `assert.true` or `assert.false` for boolean assertions." |
There was a problem hiding this comment.
Sounds good, adopted your suggestions!
bmish
force-pushed
the
no-assert-equal-boolean
branch
from
27391ed to
bd85fe0
Compare
platinumazure
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For enforcing usage of new
assert.true(...)orassert.false(...)assertions.