Allow ESLint peer dependency to include v6 and v7 #113
+119
−230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platinumazure
requested changes
Aug 31, 2020
package.json
Outdated
| @@ -33,7 +33,7 @@ | |||
| "shelljs": "^0.8.4" | |||
| }, | |||
| "peerDepencencies": { | |||
| "eslint": ">=4.15.0 <6.0.0" | |||
| "eslint": ">=4.15.0" | |||
There was a problem hiding this comment.
Can we specify <8.0.0 please? This is in case 8.0.0 has a breaking change for plugin consumers.
Also, it might be good to ensure the devDependency for ESLint is at latest, so we can use CI to make sure the plugin won't have problems. Thanks!
There was a problem hiding this comment.
Fixed! Thanks for the explanation.
bmish
changed the title
platinumazure
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint v6 and v7 have been out for a while.
The upcoming NPM v7 will also automatically install missing peer dependencies and we don't want it to be be installing old versions of ESLint due to this bug.
Fixes #112.