Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autogenerated rules table to README #110

Merged
merged 1 commit into from
Aug 30, 2020

Conversation

bmish
Copy link
Member

@bmish bmish commented Aug 30, 2020

This change redesigns the rules and configurations sections in the README.

The rules section is now an autogenerated table with the complete list of rules and emojis to indicate:

  • What configuration (recommended or two) each rule belongs to
  • Whether each rule is autofixable

A new script yarn update will automatically regenerate the rules table. I have also added a CI test to ensure the rules table is always correct and up-to-date (replacing the previous README tests).

The configurations section has also been converted into a table directly above the rules table for easy reference.

This README design and script is based on the same ones used by eslint-plugin-ember and ember-template-lint.

@bmish bmish force-pushed the docs-rules-table branch from 2dbeec0 to e93e41b Compare August 30, 2020 20:57
@coveralls
Copy link

coveralls commented Aug 30, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 624a64b on bmish:docs-rules-table into b9f10e9 on platinumazure:master.

@bmish bmish force-pushed the docs-rules-table branch 3 times, most recently from c74dc96 to 38e7fa3 Compare August 30, 2020 23:13
Copy link
Collaborator

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this!

Just one question: Why did you change the nested list spacing (in README.md) to two spaces? Can that change be reverted?

This change redesigns the rules and configurations sections in the README.

The rules section is now an autogenerated table with the complete list of rules and emojis to indicate:
* What configuration (recommended or two) each rule belongs to
* Whether each rule is autofixable

A new script `yarn update` will automatically regenerate the rules table. I have also added a CI test to ensure the rules table is always correct and up-to-date (replacing the previous README tests).

The configurations section has also been converted into a table directly above the rules table for easy reference.

This README design and script is based on the same ones used by [eslint-plugin-ember](https://github.com/ember-cli/eslint-plugin-ember) and [ember-template-lint](https://github.com/ember-template-lint/ember-template-lint).
@bmish bmish force-pushed the docs-rules-table branch from 38e7fa3 to 624a64b Compare August 30, 2020 23:30
@bmish
Copy link
Member Author

bmish commented Aug 30, 2020

@platinumazure reverted that unrelated spacing change. My editor has markdownlint set to autofix violations on save which is why it was included. (we can consider adding markdownlint in the future).

@platinumazure platinumazure merged commit a5a038e into qunitjs:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants