Add tests to ensure rules have tests and basic rule doc #105
+20
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platinumazure
requested changes
Aug 28, 2020
There was a problem hiding this comment.
Thanks for this PR! Little things do make a difference and add up over time, and I agree that these are useful "rules" to enforce on the rule tests and docs.
I wanted to call out a possible improvement to a regular expression-- let me know what you think. Otherwise, this looks good to me!
Co-authored-by: Kevin Partington <platinumazure@gmail.com>
platinumazure
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two initial tests for ensuring rule consistency. I plan to follow-up with additional tests soon.
Inspired by a similar suite of rule tests in eslint-plugin-ember and ember-template-lint.