Add option to create directories #155
Conversation
smsearcy
requested review from
gaborbernat,
ofek,
Julian and
RonnyPfannschmidt
as code owners
src/platformdirs/api.py
Outdated
|
|
||
| def _ensure_path_exists(self, path: str) -> None: | ||
| if self.ensure_exists and not os.path.exists(path): | ||
| Path(path).mkdir(parents=True) |
There was a problem hiding this comment.
can't we just pass exists_ok to mkdir and avoid the if?
There was a problem hiding this comment.
Good point, I forgot about exists_ok. But just to make sure I understand, I'll still need to gate this with if self.ensure_exists:.
There was a problem hiding this comment.
yeah, just the os.path.exists is not neeeded
There was a problem hiding this comment.
Sounds good. What do you think of the name of the method being _ensure_path_exists()? I thought that having something more "conditional" would be more clear, but didn't come up with a good alternative.
There was a problem hiding this comment.
I'd be ok to drop it and just inline it where needed 🤷
There was a problem hiding this comment.
Yeah, I had thought about that, but then one spot I forgot a conditional so I decided having a simple function call was safer.
I've updated it to use exists_ok and renamed the function based on my own concerns.
Please let me know if there is anything else you'd like to see.
Optionally create directories upon use.
smsearcy
force-pushed
the
120-ensure-directories-exist
branch
from
d644f84
to
4663bf8
Compare
|
@gaborbernat or @smsearcy |
Optionally create directories upon use, based on the
ensure_existsargument.Fixes #120
While documenting the
ensure_existsargument on the different functions, I noticed a few spots where theroaminglink was broken, so I fixed those. I can back that out if you'd prefer.