Protect against injecting javascript:URI into edited href tags #934
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates the chance that someone could make an evil custom theme.
There was a problem hiding this comment.
Hiya, @planetmilesm ! Thanks so much for catching this. I was able to avoid a 404 by prepending a dot before your fix. Feel free to accept changes. Otherwise, DM me to discuss?
<a href="./{{ 'get-started/quick-start-guide' | url }}" title="Get Started" class="md-button md-button--primary md-button--teriary">
Get started
</a>
<a href="./{{ 'get-started/get-your-planet-account' | url }}" title="Get your Planet account" class="md-button md-button--secondary">
Get a Planet account
</a>
Co-authored-by: JuLee Burdekin <91982271+JuLeeAtPlanet@users.noreply.github.com>
Co-authored-by: JuLee Burdekin <91982271+JuLeeAtPlanet@users.noreply.github.com>
jreiberkyle
approved these changes
May 5, 2023
jreiberkyle
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the chance that someone could make an evil custom theme. Potentially someone could add a javascript:URI into the edited href tags, which could allow them to craft a malicious custom theme which links to a fake planet website.