Skip to content

Match search_update interface to update-search cli interface #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

jreiberkyle
Copy link
Contributor

Related Issue(s):

Closes #908

Proposed Changes:

For inclusion in changelog (if applicable):

  1. Match search_update interface to update-search cli interface. Fixes CLI bug

Not intended for changelog:

Diff of User Interface

Old behavior:

search = await cl.update_search(VALID_SEARCH_ID,
                                    'test',
                                    ['PSScene'],
                                    search_filter,
                                    )

New behavior:

search = await cl.update_search(VALID_SEARCH_ID,
                                    ['PSScene'],
                                    search_filter,
                                    'test')

PR Checklist:

  • This PR is as small and focused as possible
  • [] If this PR includes proposed changes for inclusion in the changelog, the title of this PR summarizes those changes and is ready for inclusion in the Changelog.
  • [] I have updated docstrings for function changes and docs in the 'docs' folder for user interface / behavior changes
  • [] This PR does not break any examples or I have updated them

(Optional) @mentions for Notifications:

@jreiberkyle jreiberkyle self-assigned this Apr 5, 2023
@kevinlacaille
Copy link
Contributor

LGTM!

Copy link
Contributor

@kevinlacaille kevinlacaille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix :)

@jreiberkyle jreiberkyle merged commit 2070fd3 into main Apr 6, 2023
@jreiberkyle jreiberkyle deleted the search-update-fix-908 branch April 6, 2023 18:26
@jreiberkyle jreiberkyle mentioned this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong order of inputs in update_search in its CLI command
2 participants