Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change search-update name/filter options/parameters to match search UI #898

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

jreiberkyle
Copy link
Contributor

@jreiberkyle jreiberkyle commented Mar 24, 2023

Related Issue(s):

Closes #890

Proposed Changes:

For inclusion in changelog (if applicable):

  1. Breaking change: Bring the UI of planet data search-update CLI command inline with planet data search and DataClient.search() by moving name and filter to required options.

Not intended for changelog:

Diff of User Interface

Old behavior:

planet data filter | planet data search-update d7c24f298c4943078cb7cb7808e989a5 test PSScene -

New behavior:

planet data filter | planet data search-update d7c24f298c4943078cb7cb7808e989a5 PSScene --filter - --name test

PR Checklist:

  • This PR is as small and focused as possible
  • If this PR includes proposed changes for inclusion in the changelog, the title of this PR summarizes those changes and is ready for inclusion in the Changelog.
  • I have updated docstrings for function changes and docs in the 'docs' folder for user interface / behavior changes
  • This PR does not break any examples or I have updated them

(Optional) @mentions for Notifications:

Sorry, something went wrong.

@cholmes cholmes mentioned this pull request Mar 24, 2023
2 tasks
Copy link
Contributor

@kevinlacaille kevinlacaille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevinlacaille
Copy link
Contributor

Are we hoping to merge this into main or rc3dev-fixes?

@jreiberkyle jreiberkyle merged commit 1b12987 into main Mar 29, 2023
@jreiberkyle jreiberkyle deleted the search-update-890 branch March 29, 2023 23:10
@jreiberkyle jreiberkyle mentioned this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change search-update to be consistent with new search.
3 participants