Run Session class tests in an event loop #881
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillies
commented
Mar 21, 2023
|
|
||
| Changed: | ||
| - Session class unit tests are marked to be run within an event loop and are | ||
| no longer skipped (#881). |
There was a problem hiding this comment.
Change log updated
sgillies
commented
Mar 21, 2023
| @@ -16,6 +17,7 @@ async def test_session_get_client(client_name, client_class): | |||
| assert isinstance(client, client_class) | |||
|
|
|||
|
|
|||
| @pytest.mark.asyncio | |||
There was a problem hiding this comment.
I lost these along the way. It would have helped if pytest failed instead of skipping. Maybe we can configure it to do so. I don't immediately see how, it seems particular to async functions.
There was a problem hiding this comment.
agreed. will keep an eye out for a way to do this.
jreiberkyle
approved these changes
Mar 21, 2023
|
as this is approved with no comments, I'll merge to unblock #882 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #879
Review please @jreiberkyle