Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sanitise pid parameter #31

Merged
merged 1 commit into from
Dec 11, 2019
Merged

fix: sanitise pid parameter #31

merged 1 commit into from
Dec 11, 2019

Conversation

robcresswell
Copy link
Contributor

This patch adds a simple check to the process ID passed in, ensuring it is a number, and throwing an error otherwise. The aim is to fix the issue explained here:

Fixes: #30

This patch adds a simple check to the process ID passed in, ensuring it
is a number, and throwing an error otherwise. The aim is to fix the
issue explained here:

- https://hackerone.com/reports/701183
- https://snyk.io/vuln/SNYK-JS-TREEKILL-536781

Fixes: #30
Copy link
Collaborator

@billiegoose billiegoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@billiegoose billiegoose merged commit ff73dbf into pkrumins:master Dec 11, 2019
@robcresswell robcresswell deleted the fix/command-injection branch December 12, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command Injection Reported
2 participants