Document the weirdness of the reversal of arguments to SSH_FXP_SYMLINK #525
+7
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reversal of arguments was documented in the
encoding/ssh/filexfer.SymlinkPacket
but had an unnoticed bug (odd coincidences) that pointed people to section 3.1 not 4.1.The full comment with fix has been also brought into the
sshFxpSymlinkPacket
body to document also there why the arguments are reversed.