Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MemProfileType to allow overriding type of memory profile #54

Merged
merged 2 commits into from
May 20, 2020
Merged

Add MemProfileType to allow overriding type of memory profile #54

merged 2 commits into from
May 20, 2020

Conversation

AeroNotix
Copy link
Contributor

  • Defaults to heap
  • Allows setting to allocs to output allocation tracing profile

@AeroNotix
Add MemProfileType to allow overriding type of memory profile
b6a4bf4 
* Defaults to `heap`
* Allows setting to `allocs` to output allocation tracing profile
davecheney
davecheney reviewed May 1, 2020
View reviewed changes
Copy link
Member

@davecheney davecheney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

  1. Can you please break this down to two func options as discussed below.
  2. Can you please add examples for the new options.

Thanks

profile.go Outdated Show resolved Hide resolved
@davecheney davecheney assigned davecheney and unassigned davecheney May 1, 2020
@AeroNotix AeroNotix requested a review from davecheney May 6, 2020 23:06
davecheney
davecheney approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@davecheney davecheney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@davecheney davecheney merged commit 57ebce6 into pkg:master May 20, 2020
@AeroNotix AeroNotix deleted the allow-override-memory-profile-type branch May 20, 2020 01:20
@AeroNotix
Copy link
Contributor Author

You're welcome. A pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecheney davecheney davecheney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AeroNotix @davecheney