Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fill default MToon parameters for v0 VRMs #1407

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented May 17, 2024

Sequel of #1404

This PR fills default MToon parameters for v0 VRMs.

it's very rare but some models don't include default parameters.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
it's very rare but some models doesn't include default parameters
@0b5vr 0b5vr added the bug Something isn't working label May 17, 2024
@0b5vr 0b5vr added this to the next milestone May 17, 2024
@0b5vr 0b5vr requested a review from yue4u May 17, 2024 09:28
@0b5vr 0b5vr self-assigned this May 17, 2024
Copy link
Contributor

@yue4u yue4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not check the detailed values. (Since there's no documentation those values can only be verified by creating mtoon in unity)

@0b5vr 0b5vr merged commit 25ebc4e into dev May 17, 2024
6 checks passed
@0b5vr 0b5vr deleted the v0-mtoon-default-params branch May 17, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants