fix: Fix type definition of VRM Animation #1374
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Humanoid is optional
- Properties of HumanoidHumanBones are optional
- Some bones are required but that would be handled in the implementation side
- I also fixed the `VRMC_vrm` one
See: https://github.com/vrm-c/vrm-specification/blob/2d40293a5aa21f1a5011d7a53074056bd31cbad3/specification/VRMC_vrm_animation-1.0/schema/VRMC_vrm_animation.schema.json
See: https://github.com/vrm-c/vrm-specification/blob/2d40293a5aa21f1a5011d7a53074056bd31cbad3/specification/VRMC_vrm_animation-1.0/schema/VRMC_vrm_animation.humanoid.humanBones.schema.json
it attempts to use humanoid even when it doesn't exist
|
[memo] specVersionだけが必須 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed type definition of
VRMC_vrm_animation.VRMC_vrmoneSee: https://github.com/vrm-c/vrm-specification/blob/2d40293a5aa21f1a5011d7a53074056bd31cbad3/specification/VRMC_vrm_animation-1.0/schema/VRMC_vrm_animation.schema.json
See: https://github.com/vrm-c/vrm-specification/blob/2d40293a5aa21f1a5011d7a53074056bd31cbad3/specification/VRMC_vrm_animation-1.0/schema/VRMC_vrm_animation.humanoid.humanBones.schema.json