Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to ESLint v9 #11136

Merged
merged 5 commits into from
Dec 9, 2024
Merged

chore: upgrade to ESLint v9 #11136

merged 5 commits into from
Dec 9, 2024

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Dec 6, 2024

This PR upgrades our eslint config to work with v9

For the most part the rules are the same, some have just been renamed

This work relies on this PR to the eslint repo

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Zyie Zyie requested a review from bigtimebuddy December 6, 2024 09:35
Zyie added 2 commits December 6, 2024 09:45
Copy link

codesandbox-ci bot commented Dec 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a10088c:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie
Copy link
Member Author

Zyie commented Dec 6, 2024

@bigtimebuddy do you know why knip is failing?

@bigtimebuddy
Copy link
Member

Maybe search for eslint@9 support for knip?

@Zyie Zyie marked this pull request as ready for review December 6, 2024 13:11
@Zyie Zyie requested a review from GoodBoyDigital December 9, 2024 09:24
@Zyie Zyie added this pull request to the merge queue Dec 9, 2024
Merged via the queue into dev with commit c20c74a Dec 9, 2024
6 checks passed
@Zyie Zyie deleted the chore/eslint-v9 branch December 9, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants