Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing package: orjson #237

Open
3 of 4 tasks
DaAwesomeP opened this issue Sep 3, 2021 · 10 comments
Open
3 of 4 tasks

Missing package: orjson #237

DaAwesomeP opened this issue Sep 3, 2021 · 10 comments

Comments

@DaAwesomeP
Copy link

Package name

orjson

Package version

all

PyPI URL

https://pypi.org/project/orjson/

piwheels URL

https://www.piwheels.org/project/orjson/

Python version

  • Python 3.5
  • Python 3.7
  • Python 3.9

I am the maintainer

  • Yes

More information

I am unsure if it is just missing a dependency or if it can't be built directly from setup.py.

https://github.com/ijl/orjson#packaging

@DaAwesomeP
Copy link
Author

Hello! Just checking in on this. Would it be possible to see the logs so I can assist in troubleshooting/solving?

@bennuttall
Copy link
Member

Build log: http://paste.debian.net/1212412/

2021-08-20T22:01:18,246     Running command /usr/bin/python3 /usr/local/lib/python3.9/dist-packages/pip/_vendor/pep517/in_process/_in_process.py prepare_metadata_for_build_wheel /tmp/tmpamj5j7f6
2021-08-20T22:01:18,543     💥 maturin failed                                               
2021-08-20T22:01:18,544       Caused by: Cargo metadata failed. Does your crate compile with `cargo build`?
2021-08-20T22:01:18,544       Caused by: `cargo metadata` exited with an error: error: failed to parse manifest at `/tmp/pip-wheel-an5a4a92/orjson_6776aa522a6845f0b3ec3a95fba399ce/Cargo.toml`
                                                                                                                             
2021-08-20T22:01:18,544     Caused by:                      
2021-08-20T22:01:18,544       feature `resolver` is required                                                                  
                                                            
2021-08-20T22:01:18,545       consider adding `cargo-features = ["resolver"]` to the manifest

@bennuttall bennuttall added this to Blocked (piwheels issue) in Packages Feb 25, 2022
@bennuttall bennuttall moved this from Blocked (piwheels issue) to Waiting for response in Packages Feb 25, 2022
@messense
Copy link

The Rust version 1.48 on Debian stable is too lower for orjson to build, @bennuttall what was the reason for piwheels/piwheels#272 may I ask?

@bennuttall
Copy link
Member

It's explained here: #188 (comment)

Maybe things have moved on from then?

@messense
Copy link

Thanks for the pointer.

Rustup is not safe for concurrent use (see rust-lang/rustup#988) and when used concurrently will corrupt it's working area (see rust-lang/rustup#2417).

I think this is fine for piwheels since it's only used once for installation? If it's proxies are causing issues I guess we can just install a standalone rustc/cargo without these proxies.

Cargo uses locks for safety, but these will not scale to large numbers of users, because they are not RW locks, they are mutexes.

I don't think there will be very large concurrent Cargo builds in piwheels so it's acceptable?

@bennuttall
Copy link
Member

Actually sorry I don't think that is an accurate representation of the issue. IIRC the problem was that that adding rustup to our deploy script meant that it installed only for the root user, not for the user that would be building the package.

@messense
Copy link

messense commented Aug 21, 2022

That should be solvable by switching to install as the build user with su - username -c "install rust command" ?

Edit: the full command is su - piwheels -c "curl https://sh.rustup.rs -sSf | sh -s -- -y"

@bennuttall
Copy link
Member

Thanks. I'll give it a try and see.

@reaperhulk
Copy link

The rustc version is now affecting cryptography 38.0.x piwheel builds on buster as well since it requires >=1.48.

@Mike6gPerso
Copy link

I successfully compilet orjson 3.8.6 on a Raspberry Pi Model B Plus Rev 1.2 (armv6)
How can i upload it to make it available to everyone ? !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Packages
  
Waiting for response
Development

No branches or pull requests

5 participants