Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Childlogger Loglevel not respected in the browser #960

Open
KeKs0r opened this issue Feb 5, 2021 · 5 comments
Open

Childlogger Loglevel not respected in the browser #960

KeKs0r opened this issue Feb 5, 2021 · 5 comments

Comments

@KeKs0r
Copy link

KeKs0r commented Feb 5, 2021

Hi,

I am using pino in the browser, since I have some parts of my application that are used in the browser as well as on node.

When using pino in the browser, it seems that different log levels for Child loggers are not working:
Here is my root logger

const logger = pino({
    level: 'info',ser: {
        asObject: false,
        serialize: false,

        transmit: {
            level: 'error',
            send: function (level, logEvent) {
             //... Send error to sentry
            },
        },
    },
})

const childLogger = logger.child({name:'child', level:'debug'})

logger.debug("Root Logger Debug") // not logged
logger.info("Root Info") // logged
childLogger.debug("Child Debug") // Not logged, but I think it should
childLogger.info("Child Info") // logged

The output looks like this
image

It seems the level for the child logger, is just taken as additional property, instead of changing the level of the child logger.

@mcollina
Copy link
Member

mcollina commented Feb 5, 2021

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

@jakobrosenberg
Copy link

jakobrosenberg commented May 8, 2021

I had a similar issue which I solved in Chrome. Not sure if it's relevant.

image

@NicoVogel
Copy link
Contributor

I have the same problem in the browser.
Here a short reproducible setup: https://stackblitz.com/edit/typescript-5ka82t?devToolsHeight=33&file=index.ts

@mcollina As this feature will be quite handy in the upcoming future for us, I will look into it.

@GeorgEchterling
Copy link

The fix in #1725 only works partially. Setting the level via child.level = "debug" works, but providing it as an option in root.child() does not:

const root = pino({ level: "info" })
root.info("OK: root info WILL be logged.")
root.debug("OK: root debug will NOT be logged.")

const child1 = root.child({})
child1.level = "debug"
child1.info("OK: child1 info WILL be logged.")
child1.debug("OK: child1 debug WILL be logged.")

const child2 = root.child({}, { level: "debug" })
child2.info("OK: child2 info WILL be logged.")
child2.debug("ERROR: child2 debug will NOT be logged.") // <--

@NicoVogel
Copy link
Contributor

@GeorgEchterling the code for the browser logger takes a while to get into. Don't know if I will manage to work on it in the near future to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants