Disable FinalizationRegistry if node code coverage is active #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
CI does not seem happy about it. Also, we need to detect code coverage in the actual library code? 🤢 |
|
There is literally no way around it until Node.js and V8 fixes this bug. If node code coverage is used together with a finalizationregistry... there is a high chance of a race condition that would make the a process not terminate. Those tests that fails are not effected by this change, as the patched problem does not affect our test harness (we don't use C8). |
jsumners
approved these changes
Oct 1, 2023
mcollina
deleted the
disable-finalization-registry-on-node-code-coverage
branch
renovate bot
added a commit
to fwouts/previewjs
that referenced
this pull request
Oct 2, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`^8.15.1` -> `^8.15.3`](https://renovatebot.com/diffs/npm/pino/8.15.1/8.15.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.15.3`](https://togithub.com/pinojs/pino/releases/tag/v8.15.3) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.2...v8.15.3) #### What's Changed - Disable FinalizationRegistry if node code coverage is active by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1819 **Full Changelog**: pinojs/pino@v8.15.2...v8.15.3 ### [`v8.15.2`](https://togithub.com/pinojs/pino/releases/tag/v8.15.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.1...v8.15.2) #### What's Changed - enable named export in browser.js by [@​tarunrajput](https://togithub.com/tarunrajput) in [pinojs/pino#1803 - Fix improperly placed quote by [@​Artrix9095](https://togithub.com/Artrix9095) in [pinojs/pino#1810 - export the LoggerExtras interface by [@​ethanniser](https://togithub.com/ethanniser) in [pinojs/pino#1813 #### New Contributors - [@​Artrix9095](https://togithub.com/Artrix9095) made their first contribution in [pinojs/pino#1810 - [@​ethanniser](https://togithub.com/ethanniser) made their first contribution in [pinojs/pino#1813 **Full Changelog**: pinojs/pino@v8.15.1...v8.15.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/fwouts/previewjs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bodinsamuel
pushed a commit
to specfy/specfy
that referenced
this pull request
Oct 25, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.15.1` -> `8.16.1`](https://renovatebot.com/diffs/npm/pino/8.15.1/8.16.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.16.1`](https://togithub.com/pinojs/pino/releases/tag/v8.16.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.16.0...v8.16.1) #### What's Changed - Support Node.js v21 by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1834 **Full Changelog**: pinojs/pino@v8.16.0...v8.16.1 ### [`v8.16.0`](https://togithub.com/pinojs/pino/releases/tag/v8.16.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.7...v8.16.0) #### What's Changed - allow passing callback to flush by [@​rluvaton](https://togithub.com/rluvaton) in [pinojs/pino#1827 **Full Changelog**: pinojs/pino@v8.15.7...v8.16.0 ### [`v8.15.7`](https://togithub.com/pinojs/pino/releases/tag/v8.15.7) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.6...v8.15.7) #### What's Changed - update flush function type by [@​rluvaton](https://togithub.com/rluvaton) in [pinojs/pino#1824 - Fix Node.js in CITGM (v18.x) by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1828 **Full Changelog**: pinojs/pino@v8.15.6...v8.15.7 ### [`v8.15.6`](https://togithub.com/pinojs/pino/releases/tag/v8.15.6) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.5...v8.15.6) #### What's Changed - Fix flaky test in CITGM by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1826 **Full Changelog**: pinojs/pino@v8.15.5...v8.15.6 ### [`v8.15.5`](https://togithub.com/pinojs/pino/releases/tag/v8.15.5) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.4...v8.15.5) #### What's Changed - Fix broken test by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1825 **Full Changelog**: pinojs/pino@v8.15.4...v8.15.5 ### [`v8.15.4`](https://togithub.com/pinojs/pino/releases/tag/v8.15.4) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.3...v8.15.4) #### What's Changed - build(deps): bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1822 - feat: auto completion for `level` by [@​bogeychan](https://togithub.com/bogeychan) in [pinojs/pino#1808 #### New Contributors - [@​bogeychan](https://togithub.com/bogeychan) made their first contribution in [pinojs/pino#1808 **Full Changelog**: pinojs/pino@v8.15.3...v8.15.4 ### [`v8.15.3`](https://togithub.com/pinojs/pino/releases/tag/v8.15.3) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.2...v8.15.3) #### What's Changed - Disable FinalizationRegistry if node code coverage is active by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1819 **Full Changelog**: pinojs/pino@v8.15.2...v8.15.3 ### [`v8.15.2`](https://togithub.com/pinojs/pino/releases/tag/v8.15.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.1...v8.15.2) #### What's Changed - enable named export in browser.js by [@​tarunrajput](https://togithub.com/tarunrajput) in [pinojs/pino#1803 - Fix improperly placed quote by [@​Artrix9095](https://togithub.com/Artrix9095) in [pinojs/pino#1810 - export the LoggerExtras interface by [@​ethanniser](https://togithub.com/ethanniser) in [pinojs/pino#1813 #### New Contributors - [@​Artrix9095](https://togithub.com/Artrix9095) made their first contribution in [pinojs/pino#1810 - [@​ethanniser](https://togithub.com/ethanniser) made their first contribution in [pinojs/pino#1813 **Full Changelog**: pinojs/pino@v8.15.1...v8.15.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to redwoodjs/redwood
that referenced
this pull request
Nov 15, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.15.1` -> `8.16.1`](https://renovatebot.com/diffs/npm/pino/8.15.1/8.16.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.16.1`](https://togithub.com/pinojs/pino/releases/tag/v8.16.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.16.0...v8.16.1) #### What's Changed - Support Node.js v21 by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1834 **Full Changelog**: pinojs/pino@v8.16.0...v8.16.1 ### [`v8.16.0`](https://togithub.com/pinojs/pino/releases/tag/v8.16.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.7...v8.16.0) #### What's Changed - allow passing callback to flush by [@​rluvaton](https://togithub.com/rluvaton) in [pinojs/pino#1827 **Full Changelog**: pinojs/pino@v8.15.7...v8.16.0 ### [`v8.15.7`](https://togithub.com/pinojs/pino/releases/tag/v8.15.7) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.6...v8.15.7) #### What's Changed - update flush function type by [@​rluvaton](https://togithub.com/rluvaton) in [pinojs/pino#1824 - Fix Node.js in CITGM (v18.x) by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1828 **Full Changelog**: pinojs/pino@v8.15.6...v8.15.7 ### [`v8.15.6`](https://togithub.com/pinojs/pino/releases/tag/v8.15.6) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.5...v8.15.6) #### What's Changed - Fix flaky test in CITGM by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1826 **Full Changelog**: pinojs/pino@v8.15.5...v8.15.6 ### [`v8.15.5`](https://togithub.com/pinojs/pino/releases/tag/v8.15.5) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.4...v8.15.5) #### What's Changed - Fix broken test by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1825 **Full Changelog**: pinojs/pino@v8.15.4...v8.15.5 ### [`v8.15.4`](https://togithub.com/pinojs/pino/releases/tag/v8.15.4) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.3...v8.15.4) #### What's Changed - build(deps): bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1822 - feat: auto completion for `level` by [@​bogeychan](https://togithub.com/bogeychan) in [pinojs/pino#1808 #### New Contributors - [@​bogeychan](https://togithub.com/bogeychan) made their first contribution in [pinojs/pino#1808 **Full Changelog**: pinojs/pino@v8.15.3...v8.15.4 ### [`v8.15.3`](https://togithub.com/pinojs/pino/releases/tag/v8.15.3) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.2...v8.15.3) #### What's Changed - Disable FinalizationRegistry if node code coverage is active by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1819 **Full Changelog**: pinojs/pino@v8.15.2...v8.15.3 ### [`v8.15.2`](https://togithub.com/pinojs/pino/releases/tag/v8.15.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.1...v8.15.2) #### What's Changed - enable named export in browser.js by [@​tarunrajput](https://togithub.com/tarunrajput) in [pinojs/pino#1803 - Fix improperly placed quote by [@​Artrix9095](https://togithub.com/Artrix9095) in [pinojs/pino#1810 - export the LoggerExtras interface by [@​ethanniser](https://togithub.com/ethanniser) in [pinojs/pino#1813 #### New Contributors - [@​Artrix9095](https://togithub.com/Artrix9095) made their first contribution in [pinojs/pino#1810 - [@​ethanniser](https://togithub.com/ethanniser) made their first contribution in [pinojs/pino#1813 **Full Changelog**: pinojs/pino@v8.15.1...v8.15.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar
pushed a commit
to redwoodjs/redwood
that referenced
this pull request
Nov 16, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.15.1` -> `8.16.1`](https://renovatebot.com/diffs/npm/pino/8.15.1/8.16.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.16.1`](https://togithub.com/pinojs/pino/releases/tag/v8.16.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.16.0...v8.16.1) #### What's Changed - Support Node.js v21 by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1834 **Full Changelog**: pinojs/pino@v8.16.0...v8.16.1 ### [`v8.16.0`](https://togithub.com/pinojs/pino/releases/tag/v8.16.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.7...v8.16.0) #### What's Changed - allow passing callback to flush by [@​rluvaton](https://togithub.com/rluvaton) in [pinojs/pino#1827 **Full Changelog**: pinojs/pino@v8.15.7...v8.16.0 ### [`v8.15.7`](https://togithub.com/pinojs/pino/releases/tag/v8.15.7) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.6...v8.15.7) #### What's Changed - update flush function type by [@​rluvaton](https://togithub.com/rluvaton) in [pinojs/pino#1824 - Fix Node.js in CITGM (v18.x) by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1828 **Full Changelog**: pinojs/pino@v8.15.6...v8.15.7 ### [`v8.15.6`](https://togithub.com/pinojs/pino/releases/tag/v8.15.6) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.5...v8.15.6) #### What's Changed - Fix flaky test in CITGM by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1826 **Full Changelog**: pinojs/pino@v8.15.5...v8.15.6 ### [`v8.15.5`](https://togithub.com/pinojs/pino/releases/tag/v8.15.5) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.4...v8.15.5) #### What's Changed - Fix broken test by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1825 **Full Changelog**: pinojs/pino@v8.15.4...v8.15.5 ### [`v8.15.4`](https://togithub.com/pinojs/pino/releases/tag/v8.15.4) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.3...v8.15.4) #### What's Changed - build(deps): bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1822 - feat: auto completion for `level` by [@​bogeychan](https://togithub.com/bogeychan) in [pinojs/pino#1808 #### New Contributors - [@​bogeychan](https://togithub.com/bogeychan) made their first contribution in [pinojs/pino#1808 **Full Changelog**: pinojs/pino@v8.15.3...v8.15.4 ### [`v8.15.3`](https://togithub.com/pinojs/pino/releases/tag/v8.15.3) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.2...v8.15.3) #### What's Changed - Disable FinalizationRegistry if node code coverage is active by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1819 **Full Changelog**: pinojs/pino@v8.15.2...v8.15.3 ### [`v8.15.2`](https://togithub.com/pinojs/pino/releases/tag/v8.15.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.15.1...v8.15.2) #### What's Changed - enable named export in browser.js by [@​tarunrajput](https://togithub.com/tarunrajput) in [pinojs/pino#1803 - Fix improperly placed quote by [@​Artrix9095](https://togithub.com/Artrix9095) in [pinojs/pino#1810 - export the LoggerExtras interface by [@​ethanniser](https://togithub.com/ethanniser) in [pinojs/pino#1813 #### New Contributors - [@​Artrix9095](https://togithub.com/Artrix9095) made their first contribution in [pinojs/pino#1810 - [@​ethanniser](https://togithub.com/ethanniser) made their first contribution in [pinojs/pino#1813 **Full Changelog**: pinojs/pino@v8.15.1...v8.15.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See nodejs/node#49344 (comment) for more details, this has been the source of some of the flakyness we have been seeing.