Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync models from pinecone-protos #315

Merged
merged 4 commits into from Feb 22, 2024
Merged

Conversation

fsxfreak
Copy link
Contributor

Problem

See context in #313. This PR also includes other changes such as renaming vector_operations_api to data_plane_api and updating documentation.

Solution

Followed steps to regenerate the python client from the protos.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

@fsxfreak fsxfreak requested a review from jhamon February 21, 2024 17:15
@fsxfreak fsxfreak marked this pull request as ready for review February 21, 2024 17:16
Copy link
Collaborator

@jhamon jhamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit puzzled why the tests did not kick off for this PR. But I would expect a few things to fail because of ManageIndexesApi getting renamed to DataPlaneApi. This class is referenced inside of pinecone/control/pinecone.py and pinecone/control/index_host_store.py which need to be changed to account for the rename.

I misread the diff because of how github presented it, although some stuff did get renamed that should require changes outside the generated directory. E.g. VectorServerApi to DataPlaneApi and delete to delete_alt. I pushed a whitespace change to trigger the tests which should hopefully highlight that change is needed; I'm not sure why they didn't run when you opened this PR.

@jhamon jhamon changed the title Sync models from pinecone-protos-0f9eedd Sync models from pinecone-protos Feb 22, 2024
@jhamon jhamon merged commit e257894 into main Feb 22, 2024
124 checks passed
@jhamon jhamon deleted the fsxfreak/sync-pinecone-protos-0f9eedd branch February 22, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants