Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytest-timeout to support python >= 3.12 #314

Merged
merged 1 commit into from Feb 21, 2024

Conversation

mjvankampen
Copy link
Contributor

Problem

I could not run unit tests because pytest-timeout relies on distutils which was removed in python 3.12

Solution

Updated pytest-timeout

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Run all unit tests. Does not impact the actual client.

@jhamon
Copy link
Collaborator

jhamon commented Feb 21, 2024

Looks good, thanks.

@jhamon jhamon merged commit 17b33e7 into pinecone-io:main Feb 21, 2024
2 checks passed
@mjvankampen mjvankampen deleted the fix/test-python-3.12 branch February 26, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants