Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configure_index index for new API #281

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

jhamon
Copy link
Collaborator

@jhamon jhamon commented Jan 15, 2024

Problem

The shape of the configure_index shape has changed, so we need to pass different stuff.

Solution

  • Construct new request body
  • Add minimal integration test. I just want to see the request succeed for now. The time needed for changes to take effect is variable, and I'm in a bit of a rush. So I don't want to do a bunch of polling for status updates in my test to verify the server actually did the correct thing.
  • Delete some other legacy tests in integ/ that have been disabled for a while now.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Test Plan

New test added.

@jhamon jhamon merged commit 9a27fef into main Jan 15, 2024
64 checks passed
@jhamon jhamon deleted the jhamon/fix-configure-index branch January 15, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant