Add missing certifi dependency #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin-denoble
approved these changes
Jan 13, 2024
jhamon
added a commit
that referenced
this pull request
Jan 14, 2024
## Problem
Recent integration testing with our published dev releases shows we are
missing a dependency: `certifi`.
```
Traceback (most recent call last):
File "/home/runner/work/pinecone-python-client/pinecone-python-client/scripts/3.x/delete-all-indexes.py", line 4, in <module>
from pinecone import Pinecone
File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/pinecone/__init__.py", line 4, in <module>
from .config import *
File "/opt/hostedtoolcache/Python/3.9.18/x[64](https://github.com/pinecone-io/pinecone-python-client/actions/runs/7514956364/job/20458392131#step:3:69)/lib/python3.9/site-packages/pinecone/config/__init__.py", line 4, in <module>
from .config import ConfigBuilder, Config
File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/pinecone/config/config.py", line 5, in <module>
from pinecone.config.openapi import OpenApiConfigFactory
File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/pinecone/config/openapi.py", line 4, in <module>
import certifi
ModuleNotFoundError: No module named 'certifi'
```
## Solution
We need to declare a direct dependency on `certifi`, which is used when
we setup configuration to get information about current SSL certs. We
used to get this as a transitive dependency when we had a dependency on
the `requests` package, but that was recently removed while pruning
unused dependencies.
The `certifi` package does not follow semver (versions are date based)
and should ideally always be on the latest version. But since we are
developing a library that needs broad compatibility we will specify a
very broad range to be compatible with everyone's apps and other
libraries that may be pinned to specific versions or narrow ranges.
## Type of Change
- [x] Bug fix (non-breaking change which fixes an issue)
## Test Plan
Need to build a new dev release and rerun install-based integration
test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Recent integration testing with our published dev releases shows we are missing a dependency:
certifi.Solution
We need to declare a direct dependency on
certifi, which is used when we setup configuration to get information about current SSL certs. We used to get this as a transitive dependency when we had a dependency on therequestspackage, but that was recently removed while pruning unused dependencies.The
certifipackage does not follow semver (versions are date based) and should ideally always be on the latest version. But since we are developing a library that needs broad compatibility we will specify a very broad range to be compatible with everyone's apps and other libraries that may be pinned to specific versions or narrow ranges.Type of Change
Test Plan
Need to build a new dev release and rerun install-based integration test.