Rule visits nullsafe method call twice (once with MethodCall, once with NullsafeMethodCall)

[janedbal]

Bug report

When a rule is hooked on parent of those nodes, e.g. like this:

public function getNodeType(): string
{
    return Node::class; // or CallLike or any other common parent
}

and analyses this simple code

<?php
$var?->call();

The rule is called twice:

1. Once with MethodCall node from here
2. Once with NullsafeMethodCall node from here

Code snippet that reproduces the problem

https://phpstan.org/r/2aa36241-7795-4561-bf14-5c8d641f89fb

Expected output

Visit node only once.

Did PHPStan help you today? Did it make you happy in any way?

No response

[ondrejmirtes]

This is expected behaviour. If you hook your rule on NullsafeMethodCall, it's gonna get called. If you hook your rule on MethodCall, it's also gonna get called (I did this so that existing rules also check NullsafeMethodCall nodes which PHPStan greatly benefits from).

This means that if you hook your rule on a common ancestor like CallLike or Node, it should also get called.

You also get multiple virtual nodes for every method declaration etc.

You can fix your problem if you filter out all NullsafeMethodCall invocations because you're not interested in them.

Alternatively, we could provide some attribute like wasNullsafe to the "virtual" MethodCall.

[janedbal]

Alternatively, we could provide some attribute like wasNullsafe to the "virtual" MethodCall.

I like that.

Because currently, I was unable to distinguish (while ignoring NullsafeMethodCall to avoid this issue) if it was nullsafe or not. Here is the case (currently, I'm unable to show ?-> in the getCallToken method.

[janedbal]

I think we can close this as this has a solution now, WDYT?

[ondrejmirtes]

Yes :)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.