Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic return type resolved from callable return type wrong #9764

Closed
rarila opened this issue Aug 15, 2023 · 2 comments
Closed

Generic return type resolved from callable return type wrong #9764

rarila opened this issue Aug 15, 2023 · 2 comments
Labels
Milestone

Comments

@rarila
Copy link

rarila commented Aug 15, 2023

Bug report

As seen it the example code, a closure with return type of ''array<non-empty-string, string>'' is for some reason resolved as ''array<string, string>''.

Code snippet that reproduces the problem

https://phpstan.org/r/ef1c1257-f1a5-4a74-903d-7afaf6b91e9a

Expected output

Expected: ''array<non-empty-string, string>''
Got: ''array<string, string>''.

Did PHPStan help you today? Did it make you happy in any way?

No response

@ondrejmirtes ondrejmirtes added this to the Generics milestone Aug 15, 2023
@ondrejmirtes
Copy link
Member

Last night I came up with the idea that we mostly shouldn't generalize the generic type variables, except when they're in object generics, like Foo<int>.

Here's the resulting PR: phpstan/phpstan-src#2818

We can't do this for objects, because I want new Collection([1, 2, 3]) to become Collection<int>. This could be improved in the future thanks to this suggestion: #6732 (comment) (but it's pretty complex to implement so for now it has to wait).

The new behaviour now only applies to bleeding edge (https://phpstan.org/blog/what-is-bleeding-edge) so definitely enable it to get the taste of the future 👍

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants