New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`DOMNode::lookupNamespaceURI` allows null since eternity #9504

Closed

mvorisek opened this issue Jun 24, 2023 · 4 comments

Labels

bug

Milestone

Contributor

mvorisek commented Jun 24, 2023

Bug report

see comments in https://www.php.net/manual/en/domnode.lookupnamespaceuri.php

for some reason, phpstan thinks it is allowed only since PHP 8.0

Code snippet that reproduces the problem

https://phpstan.org/r/8113c06a-7b64-4e8f-97d1-d95f17fed821

Expected output

no error for all php versions

Did PHPStan help you today? Did it make you happy in any way?

No response

Member

ondrejmirtes commented Jun 24, 2023

Instead of opening issues for this kind of problem please follow the instructions here https://github.com/phpstan/phpstan/issues/new?assignees=&labels=&projects=&template=Function_signature_mismatch.md

ondrejmirtes added the bug label

ondrejmirtes added this to the Easy fixes milestone

Contributor Author

mvorisek commented Jul 4, 2023

should be fixed like phpstan/phpstan-src#2508

paulbalandan mentioned this issue

Fix signature of DOMNode::lookupNamespaceURI phpstan/phpstan-src#2527

Merged

Member

ondrejmirtes commented Jul 11, 2023

Fixed: phpstan/phpstan-src#2527

ondrejmirtes closed this as completed

github-actions bot commented Aug 12, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.