Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array keys type is lost through callable function call #8683

Closed
Geekimo opened this issue Jan 9, 2023 · 3 comments
Closed

array keys type is lost through callable function call #8683

Geekimo opened this issue Jan 9, 2023 · 3 comments
Labels
Milestone

Comments

@Geekimo
Copy link

Geekimo commented Jan 9, 2023

Bug report

We are currently facing an issue with the following code.
We are loosing the array keys through the function which calls our callable.
The value type is ok.

Code snippet that reproduces the problem

https://phpstan.org/r/3242b627-8e7a-4b49-b863-d1ed2a8abe62

Expected output

There should be no error.

Did PHPStan help you today? Did it make you happy in any way?

Everyday. It helps us keep our code safe.

@ondrejmirtes ondrejmirtes added this to the Generics milestone Jan 9, 2023
@ondrejmirtes
Copy link
Member

Last night I came up with the idea that we mostly shouldn't generalize the generic type variables, except when they're in object generics, like Foo<int>.

Here's the resulting PR: phpstan/phpstan-src#2818

We can't do this for objects, because I want new Collection([1, 2, 3]) to become Collection<int>. This could be improved in the future thanks to this suggestion: #6732 (comment) (but it's pretty complex to implement so for now it has to wait).

The new behaviour now only applies to bleeding edge (https://phpstan.org/blog/what-is-bleeding-edge) so definitely enable it to get the taste of the future 👍

@Geekimo
Copy link
Author

Geekimo commented Dec 12, 2023

Thanks Ondrej.

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants